Skip to content

refactor(render): share accuracy disclosure#29

Open
nvphungdev wants to merge 1 commit into
optiqor:mainfrom
nvphungdev:refactor/accuracy-disclosure-constant
Open

refactor(render): share accuracy disclosure#29
nvphungdev wants to merge 1 commit into
optiqor:mainfrom
nvphungdev:refactor/accuracy-disclosure-constant

Conversation

@nvphungdev
Copy link
Copy Markdown

What

Consolidate the sandbox accuracy disclosure so CLI help text, terminal rendering, score output, diff output, and tests all use pkg/htmlrender.AccuracyDisclosure.

Why

Fixes #24

How

Removed the duplicate accuracyDisclosure and internal/render.AccuracyDisclosure constants, then imported the existing public pkg/htmlrender constant at each call site.

Testing

  • golangci-lint run passes in Docker via golangci/golangci-lint:latest
  • go test ./... passes in Docker via golang:1.24
  • go test -race ./... passes in Docker via golang:1.24
  • go vet ./... passes in Docker via golang:1.24
  • Tested locally with: docker run --rm -v "$PWD":/src -w /src golang:1.24 go test -race ./...

Checklist

  • PR title follows Conventional Commits (feat(scope): subject)
  • All commits are DCO-signed
  • No unrelated changes pulled in
  • Documentation updated where user-visible behavior changed
  • No LLM calls or telemetry introduced
  • No proprietary backend imports

@nvphungdev nvphungdev requested a review from btwshivam as a code owner May 17, 2026 02:21
@github-actions github-actions Bot added testing Test coverage and golden fixtures area/cli Cobra CLI commands and UX area/analyze Helm chart analyzer area/render Terminal renderer (TUI, HTML, JSON) labels May 17, 2026
@github-actions
Copy link
Copy Markdown

First PR — welcome aboard!

A few things to expect:

  1. CI: every PR runs build + race tests + lint on Ubuntu and macOS. If something fails, the log will tell you exactly which gate.
  2. DCO: every commit needs Signed-off-by:. git commit -s adds it automatically.
  3. Conventional Commits: PR titles like feat(analyze): new rule or fix(cli): handle X. We squash-merge by default.
  4. Review: a maintainer will review within 72 hours. Suggestions are conversations, not orders — push back if something doesn't fit your context.

If you get stuck, reply here or jump to Discussions. We want this PR to land.

@github-actions github-actions Bot added the size/S 11–50 lines label May 17, 2026
Signed-off-by: nvphungdev <283886185+nvphungdev@users.noreply.github.com>
@nvphungdev nvphungdev force-pushed the refactor/accuracy-disclosure-constant branch from 76856b9 to 01146e8 Compare May 18, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/analyze Helm chart analyzer area/cli Cobra CLI commands and UX area/render Terminal renderer (TUI, HTML, JSON) size/S 11–50 lines testing Test coverage and golden fixtures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(render): consolidate AccuracyDisclosure constant (currently 3 copies)

1 participant