feat: change dockerfile generation to always default to standard Python build command#1336
Open
AbhinavPradeep wants to merge 1 commit intomainfrom
Open
feat: change dockerfile generation to always default to standard Python build command#1336AbhinavPradeep wants to merge 1 commit intomainfrom
AbhinavPradeep wants to merge 1 commit intomainfrom
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
AbhinavPradeep
changed the title
…ill accounting for legacy setuptools build command. Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
AbhinavPradeep
force-pushed
the
abhinav/use-default-build-command
branch
from
dda28a1 to
d3e0329
Compare
behnazh-w
reviewed
Mar 26, 2026
|
|
||
| backend_install_commands = " && ".join(build_backend_commands(buildspec)) | ||
|
|
||
| modern_build_command = "python -m build --wheel -n" |
Member
There was a problem hiding this comment.
Don't we need to install wheel when we pass this option?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change dockerfile generation to always default to standard Python build command
Description of changes
Only affects dockerfile generation. Note that the dockerfile still decides to use
python setup.py bdist_wheelif it detects that a legacy build command might be required (pre Python 3.6 beforepyproject.tomlwas introduced).