Conversation
…e characters, and allow dataflow analysis to fail to analyse a workflow without crashing Macaron entirely. Signed-off-by: Nicholas Allen <nicholas.allen@oracle.com>
behnazh-w
reviewed
Mar 30, 2026
Signed-off-by: Nicholas Allen <nicholas.allen@oracle.com>
behnazh-w
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to analyse a workflow without crashing Macaron entirely.
Summary
Fixes a crash caused by github expression parser not handling non-breaking-space characters (encountered when analysing https://github.com/openjdk/lanai and https://github.com/openjdk/jdk17u-ri).
Also allows Macaron to continue even if dataflow analysis fails (in which case only analysis of the offending workflow is skipped), which is useful to mitigate the impact of analysis bugs, as well as gracefully handle cases where a workflow is genuinely malformed (e.g. in one of the workflows of pkg:pypi/jupyter-client@8.7.0).
Also improves error reporting when the dataflow analysis fails, to report the failing workflow file.
Description of changes
Related issues
Checklist
verifiedlabel should appear next to all of your commits on GitHub.