feat: Support cert config openaicompatible models#121
Open
paul-cayet wants to merge 2 commits intomainfrom
Open
feat: Support cert config openaicompatible models#121paul-cayet wants to merge 2 commits intomainfrom
paul-cayet wants to merge 2 commits intomainfrom
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
paul-cayet
changed the title
Contributor
|
Internal regression failed: Build ID #747 |
paul-cayet
force-pushed
the
support-cert-config-openaicompatible-models
branch
from
052e3ae to
243e714
Compare
dhilloulinoracle
approved these changes
Mar 27, 2026
Contributor
|
Internal regression failed: Build ID #761 |
dhilloulinoracle
approved these changes
Mar 27, 2026
cesarebernardis
approved these changes
Mar 27, 2026
|
|
||
|
|
||
| @pytest.mark.parametrize("llm_cls", [OpenAICompatibleModel, VllmModel, OllamaModel]) | ||
| def test_llm_model_serde_preserves_tls_sensitive_fields(tls_material_factory, llm_cls) -> None: |
Member
There was a problem hiding this comment.
preserves? It looks like the opposite to me, I would assume that without the components registry this test fails
| deserialized_agent = cast( | ||
| Agent, | ||
| AgentSpecLoader().load_json( | ||
| AgentSpecExporter().to_json(agent), |
Member
There was a problem hiding this comment.
I would maybe add an intermediate check to ensure that the fields that should not be exported are not in the json
| def log_message(self, format: str, *args: object) -> None: | ||
| return None | ||
|
|
||
| server = ThreadingHTTPServer(("127.0.0.1", 0), RequestHandler) |
Member
There was a problem hiding this comment.
How is the port selected? I think we should rely on the common method to get a unique one
sonleoracle
approved these changes
Mar 30, 2026
| @@ -102,6 +111,9 @@ def __init__( | |||
| base_url=host_port, | |||
| proxy=proxy, | |||
| api_key=EMPTY_API_KEY, | |||
Member
There was a problem hiding this comment.
for Ollama model, now that you are using _warn_about_runtime_only_configuration, the non-empty EMPTY_API_KEY will make Ollama always log this misleading warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for SSL certificate configuration for OpenAI-compatible LLMs and embedding models.