Open
Conversation
9a3b174 to
4f02522
Compare
|
@shayanjm Thanks! I have had problems with accessing public lists. I will test your changes. |
|
I am currently running rainbowstream using the code from this PR and can confirm streaming a list with members I do not follow is working. |
|
I've found an issue--it seems all tweets from members of the list are being shown. Including all replies. I'm unsure if this is a problem with the PR or if this is owing to some of the more obscure twitter api rules about when a mention/reply is and isn't supposed to be shown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164 - the issue was with the way list tweets were getting accessed. I added a new arg property
args.filter_idswhich takes a string of comma separated twitter IDs of users and leverages the streaming statuses/filter endpoint (https://dev.twitter.com/streaming/reference/post/statuses/filter) for efficient list streaming.The default filter functionality in draw() is still used to limit the drawn tweets to exactly what you'd expect the list timeline to return (tweets/rts/replies by the members of the list, but not all tweets at them) - hence why both
args.filter_idsandargs.filterneed to exist as arg properties. Could be made more concise by makingargs.filtera list of tuples(username, user_id), but the current implementation works.