Added quoted tweets to conversation command#237
Open
nealchandra wants to merge 1 commit intoorakaro:masterfrom
Open
Added quoted tweets to conversation command#237nealchandra wants to merge 1 commit intoorakaro:masterfrom
nealchandra wants to merge 1 commit intoorakaro:masterfrom
Conversation
nealchandra
changed the title
conversation command
orakaro
requested changes
Jul 6, 2021
Owner
orakaro
left a comment
orakaro
left a comment
There was a problem hiding this comment.
We shouldn't mix up the logic of finding quoted tweets and finding the chain of the replied tweets. Can we do this after L602 against thread_ref directly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
conversationcommand to include quoted tweets in the conversation history instead of replies only. Many users tend to use quotes as an alternative way to reply to/comment on a thread, soconversationseemed like the appropriate command to piggyback on. I noticed a few folks had requested this in #227, and the change was fairly straightforward so I thought putting it in a PR might be useful to others.