LM Descent Stage J Mission Switching#1335
Draft
TINYBOB1 wants to merge 3 commits intoorbiternassp:Orbiter2016from
Draft
LM Descent Stage J Mission Switching#1335TINYBOB1 wants to merge 3 commits intoorbiternassp:Orbiter2016from
TINYBOB1 wants to merge 3 commits intoorbiternassp:Orbiter2016from
Conversation
…on" flag in the mission file
Contributor
Author
|
After much deliberation with @maxq519, we cannot find a fix for the deflector and cask flags causing a crash at stage sep. Max believes that this is due to how the descent stage vessel is coded, loading the mesh before it loads the mission file to see if the mission is a J one, and thus cant reload the visual to use the new mesh at staging. using this for the IRL as flown missions, it works fine, since no J class LM ever had removed deflectors or a removed cask. I can finish this PR as is, but wanted yalls opinion on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the feature to switch between G/H and J mission decent stages using the "JMission" flag in the mission file.