Update LM radar self test behavior to better reflect procedures#1468
Open
rcflyinghokie wants to merge 11 commits intoorbiternassp:Orbiter2016from
Open
Update LM radar self test behavior to better reflect procedures#1468rcflyinghokie wants to merge 11 commits intoorbiternassp:Orbiter2016from
rcflyinghokie wants to merge 11 commits intoorbiternassp:Orbiter2016from
Conversation
Collaborator
Author
|
Moving to draft for now until we can implement wiring research |
Collaborator
Author
|
Happy with this as is until we figure the "whys" of all of these differences. As implemented here, this generates expected self test values per mission instead of a single hard coded value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this PR doesn't address "why" some of these were seen, it adds the correct behavior and would make the procedures properly align rather than using hardcoded Apollo 11 values for every LM. I would like to see it merged with the caveat that if/when better self test/tape meter information comes about we add it.