Skip to content

Provide type for Orbit.fetch #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bradjones1 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Provide type for Orbit.fetch #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65ece29
Provide type for Orbit.fetch
bradjones1 Apr 16, 2022
544a3fe
Clean up typing when CI environment doesn't have fetch
bradjones1 Apr 16, 2022
4e42cf7
Can we actually just do typeof fetch but make it not required?
bradjones1 Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@orbit/core/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export interface OrbitGlobal {
deprecate: (message: string, test?: boolean | (() => boolean)) => void;
uuid: () => string;
debug: boolean;
fetch?: typeof fetch;
}

// Establish the root object, `window` (`self`) in the browser, `global`
Expand Down
4 changes: 1 addition & 3 deletions packages/@orbit/jsonapi/src/jsonapi-request-processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,7 @@ export class JSONAPIRequestProcessor {
delete settings.params;
}

let fetchFn = (Orbit as any).fetch || Orbit.globals.fetch;

// console.log('fetch', fullUrl, settings, 'polyfill', fetchFn.polyfill);
let fetchFn = Orbit.fetch || Orbit.globals.fetch;

if (settings.timeout !== undefined && settings.timeout > 0) {
let timeout = settings.timeout;
Expand Down