Pass TemplateContext to CreateChangeSetCommand#604
Merged
OlafConijn merged 4 commits intoorg-formation:masterfrom Mar 15, 2025
Merged
Pass TemplateContext to CreateChangeSetCommand#604OlafConijn merged 4 commits intoorg-formation:masterfrom
OlafConijn merged 4 commits intoorg-formation:masterfrom
Conversation
Contributor
Author
|
Added TemplatingContext command argument to CreateChangeSet, PrintStack and UpdateStack Commands (because PrintStack ultimately uses UpdateStack to create it's template.) Tests are commented out to stop Github workflows from failing due to syntax/test setup issues. |
OlafConijn
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves this issue for CreateChangeSetCommand!
Want to let this flow throw the integration tests, will look at updating PrintStackCommand as well