Skip to content

[limen GEN-organvm-iv-taxis-.github-ci-green-0620] Make organvm-iv-taxis/.github CI green#11

Merged
4444J99 merged 1 commit into
mainfrom
limen/gen-organvm-iv-taxis-.github-ci-green-0620-ecee
Jun 20, 2026
Merged

[limen GEN-organvm-iv-taxis-.github-ci-green-0620] Make organvm-iv-taxis/.github CI green#11
4444J99 merged 1 commit into
mainfrom
limen/gen-organvm-iv-taxis-.github-ci-green-0620-ecee

Conversation

@4444J99

@4444J99 4444J99 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Autonomous limen dispatch of task GEN-organvm-iv-taxis-.github-ci-green-0620.

Inspect the latest FAILING checks on organvm-iv-taxis/.github's default branch, fix the root cause (lint / types / failing test / config), and confirm the checks pass. If CI is already green, add the single most valuable missing check (e.g. typecheck or test-matrix) instead. [auto-generated 2026-06-20 to keep the stream endless]

Produced in an isolated worktree off origin — review before merge.

limen task GEN-organvm-iv-taxis-.github-ci-green-0620

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5c9338359

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

run: |
if [ -f seed.yaml ]; then
python3 -c "import yaml; yaml.safe_load(open('seed.yaml'))" && echo "seed.yaml is valid YAML" || { echo "::error::seed.yaml is invalid YAML"; exit 1; }
if ruby -e "require 'yaml'; YAML.load_file('seed.yaml')"; then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Parse the entire seed.yaml stream

In the Validate seed.yaml step, this call only loads the first YAML document; Psych's own load docs state that when multiple documents are provided, the first document is returned. That means a seed.yaml like a: 1\n---\n: : : now exits 0 and prints that the file is valid even though later content is syntactically broken, whereas the previous single-document PyYAML load rejected extra/invalid documents. Use a parser that walks the full stream, such as YAML.parse_stream, or explicitly reject additional documents.

Useful? React with 👍 / 👎.

run: |
if [ -f seed.yaml ]; then
python3 -c "import yaml; yaml.safe_load(open('seed.yaml'))" && echo "seed.yaml is valid YAML" || { echo "::error::seed.yaml is invalid YAML"; exit 1; }
if ruby -e "require 'yaml'; YAML.load_file('seed.yaml')"; then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid rejecting valid YAML constructs

Because this validates by deserializing with YAML.load_file instead of doing a parse-only check, valid YAML that uses anchors/aliases (including merge keys) or unquoted timestamp/date scalars now fails before the success message: Psych's safe loader disables aliases and does not permit Date/Time classes by default. In repos that add anchors to avoid repeated seed metadata or leave YAML dates unquoted, this workflow blocks otherwise valid seed.yaml files that the previous PyYAML validation accepted.

Useful? React with 👍 / 👎.

@4444J99 4444J99 merged commit 532cf18 into main Jun 20, 2026
2 checks passed
@4444J99 4444J99 deleted the limen/gen-organvm-iv-taxis-.github-ci-green-0620-ecee branch June 20, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant