Bug 560 overfitting in plot_ratio#561
Open
RobFryer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #560
Have reduced the degrees of freedom in
plot_ratioto ensure that the smooths don't overfit the data.plot_ratiois used inreport_assessmentto display contaminant ratios for particular contaminant groups. The smooths are used to capture any changes in the ontaminant ratios over time, but are illustrative only (not used in any inference), so the amount of smoothing is a matter of common sense / judgement.Tested on the example that created the failure and also on 100 time series assessments selected at random from the 2026 OSPAR CEMP assessment for both biota and sediment