Add a timestamp to write_summary_table#563
Merged
Merged
Conversation
hallareinert
reviewed
Jul 3, 2026
|
|
||
| # create timestamp if timestamp = TRUE | ||
|
|
||
| if (timestamp) { |
Contributor
There was a problem hiding this comment.
Does it not need to say if (timestamp == TRUE)?
Contributor
Author
There was a problem hiding this comment.
Good question. It looks like the most robust thing is to use isTRUE(timestamp).
isTRUE(x) is the same as is.logical(x) && length(x) == 1 && !is.na(x) && x, so tests whether x is a logical and of length 1 and isn't missing and is TRUE
Will change and resubmit
Contributor
There was a problem hiding this comment.
I didn't know about isTRUE(x), I like it!
hallareinert
reviewed
Jul 3, 2026
hallareinert
left a comment
hallareinert
left a comment
Contributor
There was a problem hiding this comment.
On line 547, does it not need to say "if (timestamp == TRUE)"?
Contributor
Author
|
@hallareinert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #562
write_summary_tablenow produces a timestamp (as the first column of the summary table) if argumenttimestampis set toTRUE. The default is not to produce a timestamp.Tested on AMAP external data example