bug 566 p_overall_trend incorrect#567
Merged
Merged
Conversation
Contributor
Author
|
@annelaerkes @hallareinert please could one of you look at this tomorrow morning. (There will also be another couple of pull requests on their way related to this.) I can then issue release 1.0.6. Thanks! |
hallareinert
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #566
The degrees of freedom used to test for an overall trend when a smooth model has been selected are now correct.
Note that model selection is unchanged. It is just that, when a smooth model is selected, the significance of the overall trend was previously over estimated.
Tested on an AMAP assessment object