Skip to content

Change log for release 1.0.6#570

Merged
annelaerkes merged 2 commits into
osparcomm:developfrom
RobFryer:changes_1_0_6
Jul 6, 2026
Merged

Change log for release 1.0.6#570
annelaerkes merged 2 commits into
osparcomm:developfrom
RobFryer:changes_1_0_6

Conversation

@RobFryer

@RobFryer RobFryer commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Updated change log for next release

@annelaerkes annelaerkes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments here. I am confused about the p level of the non-linear component and the overall_trend. Is the p value for the smooth model not the one given in the output as the p_non_linear? But in the text it seems to be the p_overall_trend.
I understand that the text is correct and I just don't understand what is going on but if I don't understand the logic, maybe others won't either?

@RobFryer

RobFryer commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@hallareinert @annelaerkes
I've added some more explanation to the change log. Does this make more sense? I'll wait until I hear from you before I go back to the statistical interpretation pull request.
I'm conscious that I need to document properly all the columns that come out in the summary table. But that is quite a big job and I'll leave that for a later date. However, I could put in some more explanations about where the p-values come from in the statistical interpretation. I could also explicitly say what the chosen model is and which criteria was used to choose it. What do you think? (I've had questions from some AMAP users about the p-values, so there is a demand for it.) It would be a bit of work, but not nearly so much as documenting the full summary table.

@annelaerkes annelaerkes merged commit 5e55e27 into osparcomm:develop Jul 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants