Adding logging to previously silent mesh finding failure.#188
Open
ethanfowler wants to merge 1 commit intoosrf:gzweb_1.4.0from
Open
Adding logging to previously silent mesh finding failure.#188ethanfowler wants to merge 1 commit intoosrf:gzweb_1.4.0from
ethanfowler wants to merge 1 commit intoosrf:gzweb_1.4.0from
Conversation
chapulina
reviewed
Jul 17, 2020
| '". Mesh URIs using an absolute path syntax should use ' + | ||
| 'the ROS-standard directory structure of ' + | ||
| '"<package_path>/meshes/<mesh_path>", e.g. ' + | ||
| '"/home/user/workspace/src/ur_description/meshes/base.dae".'); |
Contributor
There was a problem hiding this comment.
GzWeb is not ROS-specific, do you mind rephrasing the warning so it doesn't mention ROS? I know that the comment above mentions gazebo_ros_pkgs as an example of how a user may end up here, but there are other ways in which absolute paths could be passed to Gazebo too.
How about something like:
"Mesh URIs using an absolute path syntax should be located inside a meshes directory, e.g. /home/user/workspace/src/ur_description/meshes/base.dae"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This silent failure to resolve meshes frustrated me for a while, thought I'd save someone else the trouble. Not sure which other branches/tags might want this merging?