fix(multi-client): Prevent duplicate lights when multiple clients connect#250
Merged
iche033 merged 2 commits intoosrf:masterfrom Jan 21, 2026
Merged
fix(multi-client): Prevent duplicate lights when multiple clients connect#250iche033 merged 2 commits intoosrf:masterfrom
iche033 merged 2 commits intoosrf:masterfrom
Conversation
iche033
approved these changes
Nov 18, 2025
Contributor
Author
|
Hi, it seems the CI job timed out while waiting for a runner. Could you please help re-run the failed check? @iche033 |
Contributor
|
looks like re-run option is not available for old PRs. I just closed and re-opened the PR to retrigger the checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
Issue: Light intensity accumulation with multiple client connections
Description: When multiple web clients connect to the same gzbridge instance, the existing client's scene becomes progressively brighter with each new client connection.
Symptoms:
Root Cause: The
initScene()function in gzscene.js creates a new sun light on every client initialization without checking if lights already exist, causing duplicate light sources to accumulate in the shared THREE.js scene.Impact: Visual degradation where scenes become unnaturally bright as more clients connect, making the simulation unusable for existing clients.
Reproduction: