feat: add local caps and peer-group to watchEventPeer#3410
Closed
Ivan-Pokhabov wants to merge 1 commit into
Closed
feat: add local caps and peer-group to watchEventPeer#3410Ivan-Pokhabov wants to merge 1 commit into
Ivan-Pokhabov wants to merge 1 commit into
Conversation
Ivan-Pokhabov
force-pushed
the
feat_add_params_for_watch_event
branch
from
4aa61f6 to
fe860d6
Compare
fujita
reviewed
May 24, 2026
| LocalPort: p.Transport.LocalPort, | ||
| RemotePort: p.Transport.RemotePort, | ||
| }, | ||
| AfiSafis: afiSafis, |
Member
There was a problem hiding this comment.
This sets the result of negotiatedRFList(). However, ListPath() sets the result of locally configured families.
So it's inconsistent.
I think that it would be better to let the field alone. You can get the info from LocalCaps and RemoteCaps.
Ivan-Pokhabov
force-pushed
the
feat_add_params_for_watch_event
branch
from
fe860d6 to
006afb4
Compare
Ivan-Pokhabov
changed the title
Ivan-Pokhabov
force-pushed
the
feat_add_params_for_watch_event
branch
from
006afb4 to
37e3964
Compare
Member
|
Pushed, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.