daemon: make PeerFsmOutput::CloseConnection a unit variant#356
Merged
Conversation
The Role payload was never read — all match arms in both event.rs and fsm.rs tests used CloseConnection(_). CloseConnection is only returned by on_connected() for the same role that was passed in, so the driver already knows the role from PeerSession::self.role. Remove the payload and the now-unnecessary #[allow(dead_code)] on PeerFsmOutput. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Role payload was never read — all match arms in both event.rs and fsm.rs tests used CloseConnection(_). CloseConnection is only returned by on_connected() for the same role that was passed in, so the driver already knows the role from PeerSession::self.role.
Remove the payload and the now-unnecessary #[allow(dead_code)] on PeerFsmOutput.
Assisted-by: Claude Sonnet 4.6 noreply@anthropic.com