Skip to content

fix: Use GOPROXY env variable properly #11186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
losmateusz1 wants to merge 1 commit into from
Closed

fix: Use GOPROXY env variable properly #11186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugins/package-managers/go/src/main/kotlin/GoMod.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ class GoMod(
val cleanGoPath = createOrtTempDir()
put("GOPATH", cleanGoPath.absolutePath)
put("GOPROXY", "direct")
} else if (!config.disableGoProxy && System.getenv("GOPROXY") != null) {
put("GOPROXY", System.getenv("GOPROXY"))
Comment on lines +107 to +108
Copy link
Member

@sschuberth sschuberth Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments here:

  • The !config.disableGoProxy && part is not necessary.
  • While I get what you try to do here, the original intent of disableGoProxy was really do disable the Go proxy.

Let me think about this a bit and make a proposal for improvement.

Copy link
Member

@sschuberth sschuberth Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code again, and I believe your changes should not be necessary. The code at

ort/plugins/package-managers/go/src/main/kotlin/GoMod.kt

Line 111 in 60316b7

GoCommand.run(*args, workingDir = projectDir, environment = goEnvironment).requireSuccess()

only specified additional environment variables use, on top of those available to the environment running ORT. So any set GOPROXY variable would get inherited.

Can you confirm that this is the case, @losmateusz1?

Anyway, I agree that the current option name is misleading, as it does not completely disable any set GOPROXY. I'm clarifying that in #11189.

Copy link
Author

@losmateusz1 losmateusz1 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sschuberth we can close this PR, I checked again with latest ort code and I can't reproduce the issue anymore

}
}

Expand Down