Move bone data to server#394
Merged
Merged
Conversation
# Conflicts: # boneset-api/server.js
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
| try { | ||
| const response = await axios.get(url, { timeout: 10_000 }); | ||
| return { data: response.data, status: response.status }; | ||
| const raw = await fs.readFile(resolvedPath, "utf8"); |
Collaborator
Author
There was a problem hiding this comment.
??? This code was your suggestion. But fine
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Collaborator
Author
|
@copilot Review ONLY the changes to the file |
One blocking issue in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Closes #352
A brief description/summary of your PR here. What does it add? Why is it necessary? How was the change made, and how was it tested?
Bone data is now stored directly on the server, copied over from the
databranch. The server code has been rewritten to fetch the data from these files instead of from GitHub.Screenshots
If applicable, add screenshots showing the before and after of any UI changes made.
PR Checklist
Detailed Description
A more detailed description and any additional information.
An Express endpoint is created for images with
to replace the previous functionality whereby the server would send the frontend the URL of each image. Now, the URL provided is this endpoint so that the images can be pulled from the Express server rather than GitHub.