Open
Conversation
Contributor
|
Don't change the name of the file. |
akshatkarani
requested changes
Jul 13, 2019
Member
Author
|
Ok, I will change it. |
Contributor
|
ping me when it's ready |
Member
Author
|
It's ready |
akshatkarani
requested changes
Jul 15, 2019
Contributor
akshatkarani
left a comment
akshatkarani
left a comment
There was a problem hiding this comment.
Even the author parameter should be optional, if I call get_quote() then also it should work.
Member
Author
|
Ok I will also make it optional.
…On Mon, 15 Jul 2019, 3:18 pm Akshat Karani, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Even the author parameter should be optional, if I call get_quote() then
also it should work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28?email_source=notifications&email_token=AKQXHQR7GGNEZGC6ZKK2R63P7RBVZA5CNFSM4H7EL3BKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6MYXUQ#pullrequestreview-261721042>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKQXHQU2TASXUIG67V73HALP7RBVZANCNFSM4H7EL3BA>
.
|
sunn-e
added
the
Hacktoberfest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.