Fix several cases of silent crashing on UI#922
Merged
Conversation
fatalis
commented
Jun 29, 2026
fatalis
commented
Contributor
- The UI now opens the log FD and passes it to the child process (stays alive after UI exit)
- Use PYTHONUNBUFFERED to possibly log errors before python exits
- Errors with imports / python are now logged
- Fix DB not stopping job on some types of crashes
Contributor
|
Thank you |
socrasteeze
pushed a commit
to socrasteeze/ai-toolkit
that referenced
this pull request
Jul 19, 2026
Picks up 3 upstream commits: - 7ba7e35 Fix several cases of silent crashing on UI (ostris#922) - 479c72a Add replacing triggers on prompts when caching text encoder - cd677c7 Fix issue where more than 12 samples would break sample grid One conflict, in ui/cron/actions/startJob.ts (a known fork merge-surface file). Upstream's ostris#922 added subprocess error/exit listeners, appendJobLog, and log-fd capture but kept the async-executor 'new Promise' pattern; the fork had replaced that pattern with a plain async function + outer try/catch to stop setup-code exceptions from becoming WORKER-killing unhandled rejections. Resolved per FORK_NOTES.md guidance: kept upstream's richer subprocess handling inside the fork's safe function structure, keeping both the markJobError (fork) and appendJobLog (upstream) helpers. SDTrainer.py auto-merged cleanly (upstream's trigger-injection addition and the fork's loss_sync_every changes don't overlap). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hp4mAtvGxgTSh2ZxYD7qap
socrasteeze
pushed a commit
to socrasteeze/ai-toolkit
that referenced
this pull request
Jul 19, 2026
Co-authored-by: Jaret Burkett <jaretburkett@gmail.com>
socrasteeze
added a commit
to socrasteeze/ai-toolkit
that referenced
this pull request
Jul 19, 2026
Picks up 3 upstream commits: - 7ba7e35 Fix several cases of silent crashing on UI (ostris#922) - 479c72a Add replacing triggers on prompts when caching text encoder - cd677c7 Fix issue where more than 12 samples would break sample grid One conflict, in ui/cron/actions/startJob.ts (a known fork merge-surface file). Upstream's ostris#922 added subprocess error/exit listeners, appendJobLog, and log-fd capture but kept the async-executor 'new Promise' pattern; the fork had replaced that pattern with a plain async function + outer try/catch to stop setup-code exceptions from becoming WORKER-killing unhandled rejections. Resolved per FORK_NOTES.md guidance: kept upstream's richer subprocess handling inside the fork's safe function structure, keeping both the markJobError (fork) and appendJobLog (upstream) helpers. SDTrainer.py auto-merged cleanly (upstream's trigger-injection addition and the fork's loss_sync_every changes don't overlap).
socrasteeze
added a commit
to socrasteeze/ai-toolkit
that referenced
this pull request
Jul 19, 2026
Picks up 3 upstream commits: - 7ba7e35 Fix several cases of silent crashing on UI (ostris#922) - 479c72a Add replacing triggers on prompts when caching text encoder - cd677c7 Fix issue where more than 12 samples would break sample grid One conflict, in ui/cron/actions/startJob.ts (a known fork merge-surface file). Upstream's ostris#922 added subprocess error/exit listeners, appendJobLog, and log-fd capture but kept the async-executor 'new Promise' pattern; the fork had replaced that pattern with a plain async function + outer try/catch to stop setup-code exceptions from becoming WORKER-killing unhandled rejections. Resolved per FORK_NOTES.md guidance: kept upstream's richer subprocess handling inside the fork's safe function structure, keeping both the markJobError (fork) and appendJobLog (upstream) helpers. SDTrainer.py auto-merged cleanly (upstream's trigger-injection addition and the fork's loss_sync_every changes don't overlap).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.