Skip to content

Conversation

@Olivia206
Copy link
Contributor

Le bloc CTA n'est pas aligné sur le format de static attendu dans le thème (comme pour les chapitres, cf PR #3534)
De fait, aucun crédit n'apparaît : https://example.osuny.org/fr/blocks/blocks-narratifs/appels-a-action/

  - kind: block
    template: call_to_action
    ...
    data:
      layout: accent_background
      ...   
      image:
        id: "7ea3e92d-94ee-4595-abf3-fca575b1a4c5"
        file: "7ea3e92d-94ee-4595-abf3-fca575b1a4c5"

      alt: >-
        CTA simple texte

      credit: >-
        <p><a href="https://www.instagram.com/daniellfaro/" target="_blank" rel="noreferrer">Daniel Faro <span class="sr-only">(lien externe)</span></a>, Death to the Stock</p>

J'ai repris le bloc chapitre pour ajouter la nouvelle indentation :

  - kind: block
    template: call_to_action
    ...
    data:
      layout: accent_background
      ...   
      image:
        id: "7ea3e92d-94ee-4595-abf3-fca575b1a4c5"
        file: "7ea3e92d-94ee-4595-abf3-fca575b1a4c5"
        alt: >-
        CTA simple texte
        credit: >-
          <p><a href="https://www.instagram.com/daniellfaro/" target="_blank" rel="noreferrer">Daniel Faro <span class="sr-only">(lien externe)</span></a>, Death to the Stock</p>

      alt: >-
        CTA simple texte

      credit: >-
        <p><a href="https://www.instagram.com/daniellfaro/" target="_blank" rel="noreferrer">Daniel Faro <span class="sr-only">(lien externe)</span></a>, Death to the Stock</p>

Copy link
Member

@arnaudlevy arnaudlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peut être qu'on peut enlever 2 lignes de legacy

<%= block_component_static block, :alt, depth: 4 %>
<%= block_component_static block, :credit, depth: 4 %>
<% end %>
<%= block_component_static block, :alt %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si ce n'est plus utilisé on peut l'enlever

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalement ce n'est plus utilisé, en tout cas côté thème on a basculé sur la nouvelle indentation !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu les enlèves et j'approuve ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants