Count all blunders - #255
Open
MarcManiez wants to merge 6 commits into
Open
Conversation
Before this change, only white's blunders were showing.
Author
|
@artemispax I noticed you assign yourself ❤️ ! Thank you, and looking forward to your comments 🙏 |
Member
|
Work at Google has been wild recently. I'll get to this soon. Thanks for the PR |
Author
|
Hi @artemispax! How're things at Google? Have they slowed down any? I still think this PR could be a nice change 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello team Otrego, and thank you for providing this library 🙏 . I've been using it on a project, and realized the blunder detection wasn't tracking black's blunders (only white's).
This code does a few things, in addition to fixing the above:
FindBlunders. Hopefully you find this useful, but I'm happy to change it back if neededThanks for your review!