feat: mark psp::math functions as safe#134
Open
zetanumbers wants to merge 1 commit intooverdrivenpotato:masterfrom
Open
feat: mark psp::math functions as safe#134zetanumbers wants to merge 1 commit intooverdrivenpotato:masterfrom
psp::math functions as safe#134zetanumbers wants to merge 1 commit intooverdrivenpotato:masterfrom
Conversation
This is possible due to 9546fa1, which initializes a vfpu enabled thread inside of the `module_start`. It is unsafe to reach vfpu disabled execution context.
Contributor
|
But how is 9546fa1 relevant here? |
Contributor
Author
Um, yeah. Anyway we discussed this on discord and decided this is an appropriate change. |
Collaborator
This is where the change actually occurred. Might've been some confusion in our discussion. de9ee9d#diff-05072a5ebf71822998be8bb7f33b844dc8b68dcb256562c5291044373a6125faR220 |
Contributor
Author
|
Hm, after some thought i am not sure if we can make these functions safe. What about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is possible due to
9546fa1initialization a vfpu enabled thread inside of themodule_start. It is unsafe to get outside of vfpu context.