fix(nix): make pnpm dedup remove restored entries#641
Merged
schickling-assistant merged 1 commit intomainfrom Apr 30, 2026
Merged
fix(nix): make pnpm dedup remove restored entries#641schickling-assistant merged 1 commit intomainfrom
schickling-assistant merged 1 commit intomainfrom
Conversation
schickling-assistant
added
type:bug
schickling
force-pushed
the
schickling/2026-04-30-pnpm-dedup-writable
branch
from
bd926b0 to
9552bb3
Compare
schickling-assistant
deleted the
schickling/2026-04-30-pnpm-dedup-writable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #640: make the post-restore
.pnpmdedup step chmod restored package directories before replacing duplicate external-root entries with symlinks to the aggregate root.Rationale
Prepared workspace restore intentionally preserves store-like read-only file modes. Dedup is the step that mutates restored
.pnpmentries, so it must own the writable transition locally instead of depending on tar extraction modes or downstream builders.Validation
nixfmt nix/workspace-tools/lib/mk-pnpm-cli.nixgit diff --checkdiscord-agentbuild with fix(nix): make prepared workspace restore overwrite source files #640 restored both install roots, then failed in dedup withrm: cannot remove ... Permission denied; this patch targets that exact mutation boundary.