Skip to content

feat(pty-effect): honor PTY_SERVER_MODULE_PATH env override #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
schickling-assistant wants to merge 1 commit into from
+17 −1
Closed

feat(pty-effect): honor PTY_SERVER_MODULE_PATH env override #642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/@overeng/pty-effect/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,23 @@ const withEnvOverrides = <A, E, R>({
}).pipe(Effect.flatMap((saved) => effect.pipe(Effect.ensuring(restore(saved)))))
}

const resolvePtyServerModulePath = () => require.resolve('@myobie/pty/server')
/**
* Locate `@myobie/pty/server` for the spawned daemon child.
*
* Honors `PTY_SERVER_MODULE_PATH` first so consumers can pin the path
* explicitly. This is required when the consumer is a single-file
* `bun build --compile` binary: `require.resolve('@myobie/pty/server')`
* inside the bundle returns a `bunfs:` path that the spawned `node`
* child can't read, so the spawn fails with
* `Cannot find module '@myobie/pty/server' from '/$bunfs/root/<bin>'`.
* The wrapper script around the bundle sets the env var to a real
* on-disk path materialized in `node_modules/@myobie/pty/dist/server.js`.
*
* TODO(upstream): push this env-var override into a future
* `@overeng/pty-effect` release so consumers don't need to patch.
*/
const resolvePtyServerModulePath = () =>
process.env['PTY_SERVER_MODULE_PATH'] ?? require.resolve('@myobie/pty/server')

const spawnDaemonViaNode = (spec: PtyDaemonSpec) =>
wrapPromise({
Expand Down
Loading