Dev/jtanguy/browser k8s #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuliang
force-pushed
the
dev/jtanguy/browser-k8s
branch
4 times, most recently
from
cbbd469 to
9688aff
Compare
added 2 commits
February 9, 2026 09:45
Signed-off-by: Julien Tanguy <julien.tanguy@corp.ovh.com>
Extract rendering logic into reusable view components with dedicated packages for instances and kubernetes resources. Create shared styles, common views (loading, error, empty), and fix label alignment issues in detail views. Signed-off-by: Julien Tanguy <julien.tanguy@corp.ovh.com>
chuliang
force-pushed
the
dev/jtanguy/browser-k8s
branch
3 times, most recently
from
46e5cf4 to
d3e29d2
Compare
amstuta
force-pushed
the
dev/jtanguy/browser-k8s
branch
2 times, most recently
from
3170d9f to
3b58f20
Compare
amstuta
force-pushed
the
dev/jtanguy/browser-k8s
branch
from
3b58f20 to
be386c0
Compare
amstuta
previously approved these changes
Feb 9, 2026
amstuta
force-pushed
the
dev/jtanguy/browser-k8s
branch
from
32e439f to
41a8700
Compare
mxpetit
previously approved these changes
Feb 9, 2026
There was a problem hiding this comment.
Pull request overview
Adds Kubernetes support to the interactive “browser” TUI, including cluster listing, detail/actions, and node pool management.
Changes:
- Introduces shared view primitives (interface/base/context), common views, and centralized styling helpers.
- Adds Kubernetes-specific views (table/detail/node pools + action flows like upgrade/policy/delete and k9s integration).
- Updates the
browsercommand help text and regenerates CLI docs (adds--filteroption docs for container-registry commands).
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/services/browser/views/view.go | Adds view interface, shared context, and base view helpers for the TUI views. |
| internal/services/browser/views/styles.go | Centralizes lipgloss colors/styles and rendering helpers used across views. |
| internal/services/browser/views/kubernetes/table.go | New Kubernetes clusters table view with filtering and selection behavior. |
| internal/services/browser/views/kubernetes/detail.go | New Kubernetes cluster detail view with action selection and confirmation UX. |
| internal/services/browser/views/kubernetes/nodepools.go | Adds node pools list/detail + scale/delete flows and related messages. |
| internal/services/browser/views/instances/table.go | Adds instances table view with filtering (mirrors Kubernetes table UX). |
| internal/services/browser/views/instances/detail.go | Adds instances detail view with action confirmation UX. |
| internal/services/browser/views/common.go | Adds reusable Loading/Error/Empty views and navigation message types. |
| internal/services/browser/api.go | Wires Kubernetes API calls + wizard handlers into the browser model/controller logic. |
| internal/cmd/browser.go | Marks the browser feature as experimental in command description/help. |
| doc/ovhcloud_cloud_container-registry_ip-restrictions_registry_list.md | Regenerated docs: documents new --filter option. |
| doc/ovhcloud_cloud_container-registry_ip-restrictions_management_list.md | Regenerated docs: documents new --filter option. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rbeuque74
reviewed
Feb 9, 2026
internal/services/browser/api.go
Outdated
Comment on lines
2963
to
2978
| // Save kubeconfig to file | ||
| homeDir, err := os.UserHomeDir() | ||
| if err != nil { | ||
| return kubeActionMsg{err: fmt.Errorf("failed to get home directory: %w", err)} | ||
| } | ||
|
|
||
| kubeDir := filepath.Join(homeDir, ".kube") | ||
| if err := os.MkdirAll(kubeDir, 0700); err != nil { | ||
| return kubeActionMsg{err: fmt.Errorf("failed to create .kube directory: %w", err)} | ||
| } | ||
|
|
||
| kubeconfigPath := filepath.Join(kubeDir, "config") | ||
| if err := ioutil.WriteFile(kubeconfigPath, []byte(kubeconfig), 0600); err != nil { | ||
| return kubeActionMsg{err: fmt.Errorf("failed to save kubeconfig: %w", err)} | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Maybe should be a temp dir, what do you think ?
Here, it will override the .kube/config of the user silently
Collaborator
There was a problem hiding this comment.
you're right, will do that !
Collaborator
There was a problem hiding this comment.
@rbeuque74 I added a selector to choose where to store the kubeconfig when running command kubeconfig, and when running K9S the kubeconfig is stored in a temp dir.
Signed-off-by: Arthur Amstutz <arthur.amstutz@corp.ovh.com>
amstuta
force-pushed
the
dev/jtanguy/browser-k8s
branch
from
41a8700 to
9287d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add kubernetes part of the browser
Fixes #133 (issue)
Type of change
Please delete options that are not relevant.
Checklist:
make docgo mod tidy