Add import menu item to all addressBooks #729
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Author
|
@phil-davis Could you review this pull request or assign someone? |
|
Kudos, SonarCloud Quality Gate passed!
|
Author
|
Dear maintainers, could anyone review this pull request please? 😄 |
Member
|
These devs are no longer involved ... Let's see if there is some time left on my side to review this PR ..... |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I needed to import contacts to different address books, I added the import function to the "more" menu of each address book. With that users can import contacts to the selected address book instead of the default (via the regular import button)
A popup to selected the target address book after clicking the regular import button may be better, but this worked for me as a quick solution, since I am new to angular.
Relates to #654