chore(deps): specify at least PHP 8.3 in composer#1408
Merged
Conversation
jvillafanez
previously approved these changes
Mar 26, 2026
Contributor
Author
|
Needs CLI acceptance tests ported to GitHub workflows. |
DeepDiver1975
previously approved these changes
Jun 1, 2026
phil-davis
dismissed stale reviews from DeepDiver1975 and jvillafanez
via
July 16, 2026 09:45
7f0b6ba
phil-davis
force-pushed
the
composer-php-8.3
branch
from
July 16, 2026 09:45
f5fc060 to
7f0b6ba
Compare
Contributor
Author
|
Rebased. |
phil-davis
force-pushed
the
composer-php-8.3
branch
from
July 16, 2026 10:55
7f0b6ba to
4712f4d
Compare
DeepDiver1975
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/owncloud/market/blob/master/appinfo/info.xml already has
php min-version="8.3"We may as well specify this in
composer.jsonalso.It doesn't make much difference, because the market app doesn't have any important dependencies in
composer.jsonanyway.