Skip to content

fix: [OCISDEV-810] fix the space role and custom role checks#12540

Merged
2403905 merged 2 commits into
masterfrom
fix/OCISDEV-810
Jul 10, 2026
Merged

fix: [OCISDEV-810] fix the space role and custom role checks#12540
2403905 merged 2 commits into
masterfrom
fix/OCISDEV-810

Conversation

@2403905

@2403905 2403905 commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Related PR owncloud/reva#653

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 force-pushed the fix/OCISDEV-810 branch from b754e7b to a7533b2 Compare July 9, 2026 15:14
@kw-security

kw-security commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@2403905 2403905 force-pushed the fix/OCISDEV-810 branch from a7533b2 to 8f27b98 Compare July 9, 2026 15:15
@2403905 2403905 mentioned this pull request Jul 10, 2026
Merged
2403905 and others added 2 commits July 10, 2026 12:50
@2403905
fix: [OCISDEV-810] fix the space role and custom role checks
4095fc8
@2403905 @claude
test: [OCISDEV-810] expect 400 when updating a share to a disabled role
5f0f29f 
The update (PATCH) permission handlers now enforce the admin role
allowlist, consistent with invite. Updating a share to a disabled role
(Secure Viewer, Denied, Space Editor Without Versions) therefore returns
400 instead of the previous silent 200. Update the @issue-10768 scenarios
to assert the new, correct behavior.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@2403905 2403905 marked this pull request as ready for review July 10, 2026 11:45
@2403905 2403905 requested a review from a team as a code owner July 10, 2026 11:45
@2403905 2403905 requested review from jvillafanez and mklos-kw July 10, 2026 11:46
@2403905 2403905 merged commit aa9aa9b into master Jul 10, 2026
186 of 190 checks passed
@2403905 2403905 deleted the fix/OCISDEV-810 branch July 10, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mzner mzner mzner approved these changes
@mklos-kw mklos-kw mklos-kw approved these changes
@jvillafanez jvillafanez Awaiting requested review from jvillafanez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@2403905 @kw-security @mzner @mklos-kw