Default to standard code behaviour when outside a container

[crispyricepc]

No description provided.

[owtaylor]

Generally this makes a lot of sense. Thanks!

The actual exec needs to happen later - after we've prompted the user to install com.visualstudio.code - I think that means that the code should be structured as:

if [ -f /run/.containerenv ] ; then
    flatpak=....
    container_name=...
else
    container_name=""
fi

<prompt for install>

if [ "$container_name" = "" ] ; then
   verbose "Not in a toolbox, running Visual Studio Code directly"
   exec ...
fi

[guerra08]

I belive the verification if the user is on the host or inside a container should happen before the install prompt. Since the installation is checked with flatpak-spawn, it will fail on the host even if VSCode flatpak is already installed.

After this verification is done, we can check for the install, and later check if we should execute the VSCode flatpak on the host simply with flatpak run.

[velsinki]

Is this MR still active?
I have a working branch at 1886024 that I believe correctly implements the requested changes. I could make an MR for that, but I don't want to steal @crispyricepc's thunder :-)

[crispyricepc]

Lol I completely forgot about this. Feel free to close

[velsinki]

Haha, okay. I am not entirely sure if @owtaylor is still working on this repo though?...

[xanathar]

I didn't see this thread until it was too late and I also reinvented this wheel: https://github.com/xanathar/toolbox-vscode/tree/wip/xan/run-uncontainerized

It's on top of the latest main, so should be simpler to merge.

Let me know if you want me to proceed opening a PR.