agent: fix missing return#100
Merged
emilyalbini merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
jclulow
reviewed
May 1, 2026
| * No further notifications are required for background | ||
| * processes. | ||
| */ | ||
| return; |
Collaborator
There was a problem hiding this comment.
I think this is probably not quite sufficient. In the error path above, it looks like we'll also slip down to that assert in the case that this is a background process? I agree that this code is all a bit confused, alas.
I think we need to do the wait() either way, otherwise we might end up with zombie children, but we may want to exit early in the error path as well for background processes?
Member
Author
There was a problem hiding this comment.
Added a return in the error case too!
emilyalbini
force-pushed
the
ea-mvulumtytlot
branch
2 times, most recently
from
fe9663f to
cf9c86e
Compare
emilyalbini
force-pushed
the
ea-mvulumtytlot
branch
from
cf9c86e to
8ac9b1b
Compare
emilyalbini
force-pushed
the
ea-mvulumtytlot
branch
from
8ac9b1b to
231eb9e
Compare
jclulow
approved these changes
May 7, 2026
Collaborator
jclulow
left a comment
jclulow
left a comment
There was a problem hiding this comment.
Thanks, I think that looks right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered this while working on post tasks. I think it's missing a return here, because we'd panic if the code proceeded from here (due to the assert a few lines below).