user: implement user factory #106
Open
emilyalbini wants to merge 9 commits intoea-ptqwnqpswsuvfrom
Open
Conversation
Co-Authored-By: Joshua M. Clulow <jmc@oxide.computer>
lzrd
reviewed
May 7, 2026
lzrd
left a comment
lzrd
left a comment
There was a problem hiding this comment.
I'm currently testing against this PR and noticed one minor doc vs code issue.
| pub(crate) struct ConfigFile { | ||
| pub(crate) general: ConfigFileGeneral, | ||
| pub(crate) factory: ConfigFileFactory, | ||
| pub(crate) slots: HashMap<String, ConfigFileSlot>, |
There was a problem hiding this comment.
Disagrees with factory/users/README.md which says [slot.NAME] and [slot.hubris-1]
| buildomat target the slot supports: | ||
|
|
||
| ```toml | ||
| [slot.NAME] |
There was a problem hiding this comment.
Disagrees with factory/user/src/config.rs which uses slots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new factory for buildomat, spawning jobs in ephemeral users in the same host system running the factory. Documentation on how to use the factory is available in the factory README.
I was careful during the implementation of the factory to make sure it will always attempt to clean up after itself (never releasing a slot until the cleanup stage finishes) and that it alerts the operator when something goes wrong (by failing the worker, which triggers an hold on it: I plan in the future to add monitoring for held workers).
This PR also makes multiple changes to the agent installation to support this, each in its separate commit. I can move those to a single separate PR or multiple separate PRs if you'd prefer.
The implementation of the factory was based on @jclulow's 2024 work on a work-in-progress hubris factory.