Skip to content

Support trailing commas in package instance #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rcgoodfellow merged 1 commit into from
Mar 28, 2025
Merged

Support trailing commas in package instance #69

rcgoodfellow merged 1 commit into from
Mar 28, 2025

Conversation

@mkeeter
Copy link
Contributor

@mkeeter mkeeter commented Mar 27, 2025

I picked a random P4 test file and added a trailing comma, then fixed the parser to support it.

@mkeeter mkeeter requested a review from rcgoodfellow March 27, 2025 17:43
@mkeeter mkeeter mentioned this pull request Mar 27, 2025
Closed
rcgoodfellow
rcgoodfellow approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@rcgoodfellow rcgoodfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rcgoodfellow rcgoodfellow merged commit 9f9a18b into main Mar 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcgoodfellow rcgoodfellow rcgoodfellow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkeeter @rcgoodfellow