Skip to content

feat: support nanosecond MID (phase 2)#291

Merged
cheb0 merged 40 commits intomainfrom
232-nanos-support-phase-2
Dec 18, 2025
Merged

feat: support nanosecond MID (phase 2)#291
cheb0 merged 40 commits intomainfrom
232-nanos-support-phase-2

Conversation

@cheb0
Copy link
Member

@cheb0 cheb0 commented Dec 3, 2025

Description

Main differences with the previous PR:

  • all seq.MID are now in nanoseconds.
  • all new versions (frac version, meta version, etc) with nano MID are used everywhere by default.
  • proxy is able to extract nanosecond time from JSON docs now.
  • store protocol is now 2 which indicates that MID are sent in nanoseconds
  • frac info cache stores info as json, MID are converted to milliseconds. Info now has custom JSON marshaling methods

Fixes #232


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

cheb0 added 5 commits December 3, 2025 11:18
# Conflicts:
#	asyncsearcher/async_searcher.go
#	asyncsearcher/encoding.go
#	asyncsearcher/encoding_test.go
#	config/frac_version.go
#	config/store_protocol_version.go
#	frac/sealed/block_info.go
#	frac/sealed/seqids/blocks.go
#	frac/sealed_loader.go
#	fracmanager/frac_info_cache.go
#	indexer/meta_data.go
#	network/grpcutil/interceptors.go
#	proxy/search/async.go
#	proxy/search/docs_iterator.go
#	proxy/search/ingestor.go
#	proxy/search/streaming_doc.go
#	seq/seq.go
#	seq/seq_test.go
#	storeapi/grpc_server.go
# Conflicts:
#	asyncsearcher/async_searcher.go
#	asyncsearcher/encoding.go
#	asyncsearcher/encoding_test.go
#	config/frac_version.go
#	config/store_protocol_version.go
#	frac/sealed/block_info.go
#	frac/sealed/seqids/blocks.go
#	frac/sealed_loader.go
#	fracmanager/frac_info_cache.go
#	indexer/meta_data.go
#	network/grpcutil/interceptors.go
#	proxy/search/async.go
#	proxy/search/docs_iterator.go
#	proxy/search/ingestor.go
#	proxy/search/streaming_doc.go
#	seq/seq.go
#	seq/seq_test.go
#	storeapi/grpc_server.go
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 67.92453% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.10%. Comparing base (602c42a) to head (a8dc1d7).

Files with missing lines Patch % Lines
storeapi/client.go 0.00% 25 Missing ⚠️
asyncsearcher/async_searcher.go 20.00% 4 Missing ⚠️
frac/sealed/seqids/blocks.go 77.77% 2 Missing and 2 partials ⚠️
proxy/search/async.go 57.14% 2 Missing and 1 partial ⚠️
cmd/distribution/main.go 0.00% 2 Missing ⚠️
frac/common/info.go 88.23% 1 Missing and 1 partial ⚠️
proxy/search/ingestor.go 50.00% 2 Missing ⚠️
proxy/search/streaming_doc.go 0.00% 1 Missing and 1 partial ⚠️
storeapi/grpc_search.go 66.66% 2 Missing ⚠️
frac/processor/search.go 90.90% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   71.05%   71.10%   +0.05%     
==========================================
  Files         201      201              
  Lines       14712    14773      +61     
==========================================
+ Hits        10454    10505      +51     
- Misses       3515     3522       +7     
- Partials      743      746       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cheb0 cheb0 merged commit 4c86707 into main Dec 18, 2025
7 checks passed
@cheb0 cheb0 deleted the 232-nanos-support-phase-2 branch December 18, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support nanosecond resolution for stored documents

4 participants