Skip to content

fix: make Node microbenches more stable#376

Open
cheb0 wants to merge 2 commits intomainfrom
0-fix-agg-benchmarks-variance
Open

fix: make Node microbenches more stable#376
cheb0 wants to merge 2 commits intomainfrom
0-fix-agg-benchmarks-variance

Conversation

@cheb0
Copy link
Member

@cheb0 cheb0 commented Mar 6, 2026

Description

Use const seed and call ResetTimer. They false report degradation too often, but it's possible to slow down on them actually.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.48%. Comparing base (ad03474) to head (e0b2a32).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   71.42%   71.48%   +0.05%     
==========================================
  Files         205      206       +1     
  Lines       14910    15057     +147     
==========================================
+ Hits        10650    10764     +114     
- Misses       3484     3504      +20     
- Partials      776      789      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggDeep/size=1000-4 ad0347 96051b
4737.00 ns/op 5498.00 ns/op 1.16 🔴
AggDeep/size=10000-4 ad0347 96051b
47818.00 ns/op 56106.00 ns/op 1.17 🔴
AggWide/size=1000-4 ad0347 96051b
4780.00 ns/op 5920.00 ns/op 1.24 🔴
FindSequence_Random/medium-4 ad0347 96051b
12292.95 MB/s 11074.57 MB/s 0.90 🔴

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggDeep/size=10000-4 03387c 7bc28e
45145.00 ns/op 55798.00 ns/op 1.24 🔴
And/size=1000-4 03387c 7bc28e
4.29 ns/op 4.82 ns/op 1.12 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants