Updated RemoteSpace to have a gate for each thread, to avoid threads …#26
Open
JBcoding wants to merge 1 commit intopSpaces:masterfrom
Open
Updated RemoteSpace to have a gate for each thread, to avoid threads …#26JBcoding wants to merge 1 commit intopSpaces:masterfrom
JBcoding wants to merge 1 commit intopSpaces:masterfrom
Conversation
…with blocking calls blocking other threads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…with blocking calls blocking other threads
If two threads, T1 and T2 share a RemoteSpace object, and T1 makes a blocking call like get, then T2 can not use the RemoteSpace before T1's get terminates.
This is fixed by adding a gate for each thread, identified by the thread id.