fix: lock onmessage to prevent duplicate message handlers#25
Open
jiangheng90 wants to merge 1 commit into
Open
fix: lock onmessage to prevent duplicate message handlers#25jiangheng90 wants to merge 1 commit into
jiangheng90 wants to merge 1 commit into
Conversation
wasm-bindgen registers a message handler during mod.default() initialization. When using addEventListener for task dispatch, both handlers fire for every postMessage, causing the wasm-bindgen handler to fail on wasmworker-format messages. Lock the onmessage setter via Object.defineProperty after init so that addEventListener remains the sole message dispatch path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
wasm-bindgen's
mod.default()setsself.onmessageduring init.When wasmworker uses
addEventListener('message', ...)for task dispatch,both handlers fire. The wasm-bindgen handler cannot parse wasmworker's
message format, causing
Cannot read properties of undefined (reading 'length').Fix
Lock the
onmessagesetter viaObject.definePropertywith a no-opsetter after
mod.default()completes. Applied to bothWORKER_JSand
WORKER_JS_WITH_PRECOMPILED.Testing
Verified with 4-worker pool running mixed
#[webworker_fn]and#[webworker_channel_fn]tasks. No errors.