after_release: fix dead release trigger (winget PR never auto-fired)#66
Merged
Conversation
release.yml publishes the GitHub Release with the default GITHUB_TOKEN, and GitHub suppresses events created by that token from triggering other workflows (recursion guard). The `release: published` trigger here was dead code — every winget submission to date has been a manual workflow_dispatch. Switch to `workflow_run` on Release completion, which is exempt from the suppression. The tag arrives as workflow_run.head_branch on tag-push runs; the job guard now also requires a successful conclusion and a `v`-prefixed, hyphen-free (stable) tag. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
packetThrower
added a commit
that referenced
this pull request
Jul 17, 2026
The 'future' section described a plan superseded by after_release.yml (and its #66 trigger fix, validated on Zorite v0.9.0). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
packetThrower
added a commit
that referenced
this pull request
Jul 17, 2026
The 'future' section described a plan superseded by after_release.yml (and its #66 trigger fix, validated on Zorite v0.9.0). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The winget submission never fired automatically: release.yml publishes the Release with the default
GITHUB_TOKEN, and GitHub suppresses events created by that token from triggering other workflows (recursion guard). Therelease: publishedtrigger in after_release.yml was dead code — 4.1.3 and 4.1.4 were both submitted via manualworkflow_dispatch.Fix: trigger on
workflow_run(Release, completed) instead — exempt from the suppression. Tag comes fromworkflow_run.head_branch(the tag name on tag-push runs). Job guard now requires: successful Release conclusion,v-prefixed head_branch (filters out release.yml's own workflow_dispatch runs, which carry a branch name), no hyphen (stable only, as before).Manual
workflow_dispatchpath is unchanged as the fallback.Test plan
🤖 Generated with Claude Code