-
-
Notifications
You must be signed in to change notification settings - Fork 165
add: kitty-bin
#8213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add: kitty-bin
#8213
Conversation
| install -d "${pkgdir}/opt" | ||
| cp -r . "${pkgdir}/opt/${gives}" | ||
|
|
||
| # Symlink /usr/... -> /opt/kitty/.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The binaries are symlinked rather than installed directly to /usr/bin because they use RPATH to locate the bundled libraries. Everything else could be moved instead if that is preferable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the AUR handle this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no equivalent in the AUR because kitty is in the official Arch repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That package doesn't have the same issue because it's building kitty from source.
Another solution is patching the binaries to modify their RPATH so they load the bundled libraries from a fixed path instead of $ORIGIN/../lib. Should I try that try that instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be nice. Really what I want is less symlinks and more just simple hard paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RPATH approach is possible, but there are other hard-coded paths requiring multiple directories under /usr/lib to work: eg. /usr/lib/kitty, /usr/lib/kitty-bundled, /usr/lib/kitty-extensions. I got kitty working but kitten segfaults in this configuration for some reason.
Instead I pushed an intermediate solution that avoids symlinking anything except the binaries.
Add package for [kitty][1]: > The fast, feature-rich, GPU based terminal emulator. This installs a pre-built bundle including most of kitty's dependencies and desktop integration. [1]: https://sw.kovidgoyal.net/kitty/ Fixes pacstall#5801.
|
I noticed that in the tree printing of the package there's this: And nothing in it. |
|
That's an issue with |
Add package for kitty:
This installs a pre-built bundle including most of kitty's dependencies and desktop integration.
Fixes #5801.
Progress