Skip to content

Updated to work with newer Delphi versions#1

Open
CWBudde wants to merge 4 commits into
padcom:masterfrom
CWBudde:master
Open

Updated to work with newer Delphi versions#1
CWBudde wants to merge 4 commits into
padcom:masterfrom
CWBudde:master

Conversation

@CWBudde

@CWBudde CWBudde commented Aug 24, 2016

Copy link
Copy Markdown

No description provided.

@padcom

padcom commented Aug 24, 2016

Copy link
Copy Markdown
Owner
  1. I don't like the removal of revision from WriteProgramVersion - the revision.inc file is produced while building using ant and the provided build.xml
  2. Each and every top-level folder is spelled lower-cased and all components are in the components folder. I don't like making a distinction for submodules.
  3. The order of imports in the delcos.dpr is not arbitrary. Originally units are organized by their purpose. There are tools in the IDE to help you discover files should you need them alphabetized.

@padcom

padcom commented Aug 24, 2016

Copy link
Copy Markdown
Owner

Actually if you don't mind explaining in more details what was it that you changed other than the import of fastmm and removal of include of revision.inc that made it compatible with the newer versions of Delphi?

@CWBudde

CWBudde commented Aug 25, 2016

Copy link
Copy Markdown
Author

Sorry for the confusion, I should have splitted my changes in several commits. In fact the compatibility changes were just little. In fact I should have forward only these changes as a pull request.

The reason why I did what you mentioned is mostly because of personal preferences, hence the personal fork. This said, I couldn't figure out how the revisions.inc worked, which is why I removed it.

May I suggest to either add a .dproj file with the right configuration or a build.bat to build the project from the command line. Additionally/alternatively a howto build would be welcome in the readme.me

@padcom

padcom commented Aug 25, 2016

Copy link
Copy Markdown
Owner

Could you explain what made it work with new version of Delphi? I see only the change in removing fastmm4 in components and addition of submodule folder with ref to a github repo..

It'd be best to keep components inside the components folder - adding a submodules folder has little value and is jsut a technicality.

@CWBudde

CWBudde commented Aug 25, 2016

Copy link
Copy Markdown
Author

The changes were related to the Pascal-Parser component. It used DecimalSeparator, which has been moved to FormatSettings.DecimalSeparator. Also there was something odd with some list access.

@padcom

padcom commented Aug 25, 2016

Copy link
Copy Markdown
Owner

Let's do this: let's split this into 2 PRs - one for externalizing the FastMM component (please use the components folder instead of submodules) and once that's completed let's build on top of that and do an update so that it actually works with newer versions of Delphi. It is hard to make heads or tails otherwise.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants