Open
Conversation
test/Main.purs
Outdated
| test (WrappedRecord { propFoo: "hi", propBAR: 3, order: GT }) | ||
|
|
||
| where | ||
| test :: forall a. Generic a |
Owner
There was a problem hiding this comment.
Could you please rename this to avoid shadowing?
Owner
|
Looks good so far! Please see my comments above. |
Author
|
Thanks for the comments. I created a PR for purescript-foreign for the TypeMismatch changes. What do you think about the |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5 and snuck a small fix for #8 for record types.
This adds the options
fieldLabelModifier,constructorTagModifier, anduntagEnum.You can see examples of use in the tests but the motivating reason for each was:
fieldLabelModifier: Easy to handle snake_case json formats
constructorTagModifier: Instead of using the full constructor name + namespace, we can now just use the constructor name. eg "Data.Ordering.GT" can just be "GT"
untagEnum: when an sum type contains only simple constructors, it will serialize the values as a string instead of a TaggedObject