Skip to content

Add Azure Foundry DNS zones #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
krusty93 wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Draft

Add Azure Foundry DNS zones #1913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .nx/version-plans/version-plan-1782811807664.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
azure_core_infra: minor
---

Add Azure Foundry private DNS zones to core infrastructure.
3 changes: 3 additions & 0 deletions infra/modules/azure_core_infra/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,8 @@ locals {
"apim" = "privatelink.azure-api.net"
"appcs" = "privatelink.azconfig.io"
"redis_managed" = "privatelink.redis.azure.net"
"cognitiveservices" = "privatelink.cognitiveservices.azure.com"
"openai" = "privatelink.openai.azure.com"
"ai_services" = "privatelink.services.ai.azure.com"
}
}
9 changes: 9 additions & 0 deletions infra/modules/azure_core_infra/tests/common.tftest.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ run "core_is_correct_plan" {
error_message = "The Private DNS Zones configuration must be correct"
}

assert {
condition = alltrue([
module.dns.private_dns_zones.cognitiveservices.name == "privatelink.cognitiveservices.azure.com",
module.dns.private_dns_zones.openai.name == "privatelink.openai.azure.com",
module.dns.private_dns_zones.ai_services.name == "privatelink.services.ai.azure.com"
])
error_message = "The Azure Foundry Private DNS Zones configuration must be correct"
}

assert {
condition = try(azurerm_resource_group.test[0], "NotTestEnv") == "NotTestEnv"
error_message = "This Environment is not a Test Environment"
Expand Down
Loading