Extend cross-source finding dedup to custom analyzer sentences - #2033
Draft
mamu0 wants to merge 2 commits into
Draft
Extend cross-source finding dedup to custom analyzer sentences#2033mamu0 wants to merge 2 commits into
mamu0 wants to merge 2 commits into
Conversation
mamu0
temporarily deployed
to
bootstrapper-dev-ci
August 4, 2026 09:20 — with
GitHub Actions
Inactive
mamu0
temporarily deployed
to
bootstrapper-prod-ci
August 4, 2026 09:20 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the finding deduplication introduced for Advisor/AZQR/custom sources to also cover duplicate sentences produced by the custom (live-scan) analyzers themselves.
Previously, every sentence emitted by the per-resource analyzers (
disk.ts,vm.ts,container-app.ts, etc.) shared the genericcode: "custom.unknown"and had norecommendationId, so two custom findings describing the same problem on the same resource could never be collapsed — the existing dedup logic deliberately skips findings without arecommendationIdto avoid merging unrelated sentences on a guess.Sentences that match a known template now get a stable, per-sentence
custom.<id>identity (e.g.custom.disk.unattached,custom.low-cpu-usage), following the same<source>.<id>conventionalready used by
advisor.<id>andazqr.<id>. This lets the existing (already source-agnostic) fold logic collapse duplicate custom findings too, not just cross-source ones. Sentences with no known template are unaffected: they keepcode: "custom.unknown"and norecommendationId, and are still never collapsed on guesswork.Depends on #2026
Resolves: CES-2227