Skip to content

[ICC-262] Move to linux cosmosdb emulator - #229

Draft
gquadrati wants to merge 29 commits into
masterfrom
move-to-cosmosdb-emulator
Draft

[ICC-262] Move to linux cosmosdb emulator#229
gquadrati wants to merge 29 commits into
masterfrom
move-to-cosmosdb-emulator

Conversation

@gquadrati

@gquadrati gquadrati commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

List of Changes

Replace @zeit/cosmosdb-server

Motivation and Context

Enable the ability to test patch / batch on integration tests

How Has This Been Tested?

IT

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot

pagopa-github-bot commented Oct 26, 2022

Copy link
Copy Markdown
Contributor
Warnings
⚠️ This PR changes a total of 289 LOCs, that is more than a reasonable size of 250. Consider splitting the pull request into smaller ones.
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against f0ddb1f

@gquadrati
gquadrati force-pushed the move-to-cosmosdb-emulator branch from 15ced28 to c020b9f Compare October 26, 2022 16:02
@gquadrati
gquadrati force-pushed the move-to-cosmosdb-emulator branch from e43085b to e6025a5 Compare October 27, 2022 16:59
add delay to fixtures

fix delay

remove logs

set delay
@gquadrati
gquadrati force-pushed the move-to-cosmosdb-emulator branch from 17ceb44 to d7e6d8c Compare October 31, 2022 15:00
@gquadrati gquadrati changed the title [WIP] Move to linux cosmosdb emulator Move to linux cosmosdb emulator Oct 31, 2022
@gquadrati gquadrati changed the title Move to linux cosmosdb emulator [ICC-262] Move to linux cosmosdb emulator Oct 31, 2022
@gquadrati
gquadrati marked this pull request as ready for review October 31, 2022 18:26
@gquadrati
gquadrati requested a review from a team as a code owner October 31, 2022 18:26
@fabriziopapi

Copy link
Copy Markdown
Contributor

LGTM, but I think we should move on docker swarm or kubernates to execute this IT in the pipelines: soon we'll require a more complex services minimum ecosystem to execute a function.

@AleDore

AleDore commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

@gquadrati : It seems code review fails

@gquadrati

Copy link
Copy Markdown
Contributor Author

@AleDore yes, unfortunately there still seem to be some timing errors.. I tried to re-run it, and they are failing half of the time.

@gquadrati
gquadrati marked this pull request as draft November 4, 2022 18:46
@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@balanza balanza mentioned this pull request Dec 5, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants