Modify "makeTestData" to handle existing directory#9
Open
Sujishark wants to merge 1 commit intopaleozogt:masterfrom
Open
Modify "makeTestData" to handle existing directory#9Sujishark wants to merge 1 commit intopaleozogt:masterfrom
Sujishark wants to merge 1 commit intopaleozogt:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
org.paleozogt.gradle.zip.SymZipPluginTest.sampleBuildTestis not idempotent and fails if run twice in the same JVM, because it pollutes state shared among tests. The test fails when it tries to build a directory which is already existing.The changes ensure that the existing build directory is properly cleaned before executing
makeTestData.Please let me know if you want to discuss further about the changes.