Skip to content

TST: Add regression test for DataFrame.where inplace consistency #63259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zachyattack23 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

TST: Add regression test for DataFrame.where inplace consistency #63259

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
143139c
TST: Add regression test for DataFrame.where inplace consistency
zachyattack23 Dec 4, 2025
cd2b41d
Update pandas/tests/frame/indexing/test_where.py
zachyattack23 Dec 5, 2025
6d72476
Complete review request: remove all verbose comments except GH reference
zachyattack23 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pandas/tests/frame/indexing/test_where.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,3 +1073,23 @@ def test_where_other_nullable_dtype():
result = df.where(df > 1, other, axis=0)
expected = DataFrame({0: Series([pd.NA, 2, 3], dtype="Int64")})
tm.assert_frame_equal(result, expected)


def test_where_inplace_string_array_consistency():
# GH#46512 - inplace and non-inplace should have consistent behavior
# for StringArray with NA-like values
Copy link
Member

@mroeschke mroeschke Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all comments (and below) except GH#46512

df = DataFrame({"A": ["1", "", "3"]}, dtype="string")
df_inplace = df.copy()

# Test non-inplace
result = df.where(df != "", np.nan)

# Test inplace
df_inplace.where(df_inplace != "", np.nan, inplace=True)

# Both should produce pd.NA, not float nan
assert isinstance(result["A"]._values[1], type(pd.NA))
assert isinstance(df_inplace["A"]._values[1], type(pd.NA))

# Results should be identical
tm.assert_frame_equal(result, df_inplace)
Loading