Skip to content

Conversation

@keeminlee
Copy link
Collaborator

  • Adds crop_frames utility for flexible frame subsetting using 1-based (start, end) tuples with optional open-ended bounds (None).
  • Implements strict input validation (no overlaps, out-of-bounds, or invalid types) and consistent NumPy slicing semantics.
  • Includes unit tests verifying correct cropping, open-ended behavior, and error handling for invalid inputs.

Copy link
Collaborator

@themattinthehatt themattinthehatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make the ranges match how python would process, i.e. 0-based, left-inclusive, right-exclusive

@themattinthehatt themattinthehatt merged commit a2cd985 into main Nov 12, 2025
1 check passed
@themattinthehatt themattinthehatt deleted the s-frames_fix branch November 12, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants